feat: add build command #19
Conversation
Signed-off-by: Alessio Greggi <ale_grey_91@hotmail.it>
| var ( | ||
| inputDirectory string | ||
| saveProfile bool | ||
| profileName = "seccomp.json" |
There was a problem hiding this comment.
This one could/should be a const
|
|
||
| syscalls := make([]string, 0) | ||
| for _, fileObj := range files { | ||
| //fmt.Println("[" + fileObj.Name() + "]") |
There was a problem hiding this comment.
This looks like a left behind debug
| for _, fileObj := range files { | ||
| //fmt.Println("[" + fileObj.Name() + "]") | ||
|
|
||
| file, err := os.Open(inputDirectory + "/" + fileObj.Name()) |
There was a problem hiding this comment.
Please use filepath.Join, do not convact things like that
| } | ||
| defer profileFile.Close() | ||
|
|
||
| if err := profileFile.Chmod(0644); err != nil { |
There was a problem hiding this comment.
| if err := profileFile.Chmod(0644); err != nil { | |
| if err := profileFile.Chmod(0o644); err != nil { |
Use the octal notation
| fmt.Printf("error setting permissions to %s: %v\n", profileFile.Name(), err) | ||
| } | ||
| // write to file | ||
| fmt.Fprintln(profileFile, profile) |
There was a problem hiding this comment.
| fmt.Fprintln(profileFile, profile) | |
| err := fmt.Fprintln(profileFile, profile) | |
| if err != nil { | |
| // log something | |
| } |
| defer profileFile.Close() | ||
|
|
||
| if err := profileFile.Chmod(0644); err != nil { | ||
| fmt.Printf("error setting permissions to %s: %v\n", profileFile.Name(), err) |
There was a problem hiding this comment.
Shouldn't we return, here?
|
|
||
| profile, err := seccomp.BuildProfile(syscalls) | ||
| if err != nil { | ||
| fmt.Printf("error building seccomp profile: %v", err) |
There was a problem hiding this comment.
No return here?
How could we continue if the profile cannot be built?
|
Hi @ccoVeille, |
I find bavk our conversation in my saved item. Did you fix all the things I reported? |
Closes #9
This PR introduce the new
buildcommand that allows the user to create seccomp profiles from the collected syscalls.