fix: skip return when reading from channel #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89luca89
requested changes
Aug 8, 2024
Signed-off-by: Alessio Greggi <ale_grey_91@hotmail.it>
89luca89
approved these changes
Aug 8, 2024
ccoVeille
requested changes
Aug 8, 2024
| @@ -49,7 +49,7 @@ by passing the function name symbol and the binary args. | |||
| for _, functionSymbol := range functionSymbolList { | |||
| syscalls, err := captor.Capture(functionSymbol, args, captureOpts) | |||
| if err != nil { | |||
| return fmt.Errorf("error capturing syscall: %w", err) | |||
| fmt.Printf("error capturing syscall: %w", err) | |||
There was a problem hiding this comment.
There is no %w with Printf if I'm not wrong
Suggested change
| fmt.Printf("error capturing syscall: %w", err) | |
| fmt.Printf("error capturing syscall: %v", err) |
| @@ -49,7 +49,7 @@ by passing the function name symbol and the binary args. | |||
| for _, functionSymbol := range functionSymbolList { | |||
| syscalls, err := captor.Capture(functionSymbol, args, captureOpts) | |||
| if err != nil { | |||
| return fmt.Errorf("error capturing syscall: %w", err) | |||
| fmt.Printf("error capturing syscall: %w", err) | |||
There was a problem hiding this comment.
You could consider using
Either errors.Join to gather them all
Or fmt.Fprintf to send the errors to stderr
Suggested change
| fmt.Printf("error capturing syscall: %w", err) | |
| fmt.Fprintf(os.Stderr, "error capturing syscall: %v", err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #31