Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(integration): add integration tests and test them with a pipeline #34

Merged
merged 13 commits into from
Aug 12, 2024

Conversation

alegrey91
Copy link
Owner

Closes #33

.github/workflows/tests.yaml Show resolved Hide resolved
.github/workflows/tests.yaml Show resolved Hide resolved
.github/workflows/tests.yaml Outdated Show resolved Hide resolved
.github/workflows/tests.yaml Show resolved Hide resolved
…ted pipeline

Signed-off-by: Alessio Greggi <ale_grey_91@hotmail.it>
@alegrey91 alegrey91 marked this pull request as ready for review August 10, 2024 12:59
@alegrey91 alegrey91 requested a review from ccoVeille August 10, 2024 12:59
@alegrey91
Copy link
Owner Author

@ccoVeille I performed several changes to the code base, but finally there's a pipeline to test both unit and integration tests :)

.github/workflows/tests.yaml Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
cmd/analyze.go Outdated Show resolved Hide resolved
cmd/analyze.go Outdated Show resolved Hide resolved
cmd/analyze.go Show resolved Hide resolved
main_test.go Outdated Show resolved Hide resolved
tests/testcases/example-app/cmd/coin.go Show resolved Hide resolved
tests/testcases/example-app/main.go Outdated Show resolved Hide resolved
tests/testcases/example-app/cmd/rps.go Outdated Show resolved Hide resolved
tests/testcases/example-app/cmd/dice.go Outdated Show resolved Hide resolved
alegrey91 and others added 9 commits August 10, 2024 18:09
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
Signed-off-by: Alessio Greggi <ale_grey_91@hotmail.it>
Signed-off-by: Alessio Greggi <ale_grey_91@hotmail.it>
Signed-off-by: Alessio Greggi <ale_grey_91@hotmail.it>
Signed-off-by: Alessio Greggi <ale_grey_91@hotmail.it>
@alegrey91 alegrey91 requested a review from ccoVeille August 12, 2024 08:06
main_test.go Outdated Show resolved Hide resolved
main_test.go Outdated Show resolved Hide resolved
tests/testcases/example-app/cmd/coin.go Outdated Show resolved Hide resolved
internal/ebpf/probesfacade/captor/capture.go Show resolved Hide resolved
@@ -20,7 +20,7 @@ import (
"io"
"os"

"github.com/alegrey91/harpoon/internal/captor"
"github.com/alegrey91/harpoon/internal/ebpf/probesfacade/captor"
meta "github.com/alegrey91/harpoon/internal/metadata"
"github.com/alegrey91/harpoon/internal/writer"
"github.com/spf13/cobra"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cobra and yaml import should be before the packages of this module

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't change this

@@ -19,7 +19,7 @@ import (
"fmt"
"strings"

"github.com/alegrey91/harpoon/internal/captor"
"github.com/alegrey91/harpoon/internal/ebpf/probesfacade/captor"
"github.com/alegrey91/harpoon/internal/writer"
"github.com/spf13/cobra"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cobra should be in a separate block before the packages of the module

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is better open another issue for refactoring all these things

Copy link
Owner Author

@alegrey91 alegrey91 Aug 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be a good PR to fix all the errors reported by golangci-lint that you are going to add

cmd/analyze.go Show resolved Hide resolved
alegrey91 and others added 3 commits August 12, 2024 16:51
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
@alegrey91 alegrey91 requested a review from ccoVeille August 12, 2024 15:37
Copy link
Collaborator

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing, but why not

@alegrey91 alegrey91 merged commit ea08fde into main Aug 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration tests using testscript and create pipeline to run integration and unit tests together
2 participants