Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use shopt -s globstar to handle ** #1

Merged
merged 3 commits into from
Oct 11, 2022

Conversation

filosganga
Copy link
Contributor

By default the bash on linux has the globstar disabled, in this way the ** does not match /. Enabling it, will match ** to any string including /

action.yml Outdated
shell: 'bash'
- run: |
shopt -s globstar
tar -cvzf targets.tar.gz ${{ inputs.path }}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the file name has been changed here and thus won't be uploaded as an artifact

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦🏼

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix it, also I had by mistake added the -z option, that I have removed now

@filosganga filosganga requested a review from alehechka October 10, 2022 21:10
Copy link
Owner

@alehechka alehechka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alehechka alehechka merged commit 2089a6a into alehechka:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants