Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support proxy_url #75

Closed
mathe-matician opened this issue Oct 26, 2023 · 5 comments
Closed

Support proxy_url #75

mathe-matician opened this issue Oct 26, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@mathe-matician
Copy link

mathe-matician commented Oct 26, 2023

The original repo's master had changes to support proxy_url: https://github.com/gavinbunney/terraform-provider-kubectl/blob/8e4af599e17a3d8d73defd5cff392bbe23cc9c6f/kubernetes/provider.go#L124-L129

Since this is the now active repo, it would be great to implement support for proxy_url here.

@alekc alekc self-assigned this Oct 27, 2023
@alekc alekc added the enhancement New feature or request label Oct 27, 2023
@thpham
Copy link

thpham commented Dec 6, 2023

Would be very cool to move forward with that. @alekc , If I take some time to propose a PR, would you be ok to review, merge and do a new release ?

alekc added a commit that referenced this issue Dec 6, 2023
alekc added a commit that referenced this issue Dec 6, 2023
@alekc
Copy link
Owner

alekc commented Dec 6, 2023

released in https://github.com/alekc/terraform-provider-kubectl/releases/tag/v2.0.4-rc1 (rc version, so you need to set explicit versioning in your tf file). @mathe-matician @thpham

@alekc
Copy link
Owner

alekc commented Dec 7, 2023

Also, since you've required this functionality please confirm that it's working properly. I am a bit limited in testing it due to the nature of the requirement (don't have a proper proxy with certs or socks set up).

@thpham
Copy link

thpham commented Dec 7, 2023

This looks ok for me for now, because I never had the chance to test the original feature as it was in the main branch but not in the last release. But I will probably be able to test again over Xmas time.

@alekc
Copy link
Owner

alekc commented Dec 15, 2023

Released in 2.0.4

@alekc alekc closed this as completed Dec 15, 2023
dfroberg pushed a commit to froberg-co/terraform-provider-kubectl that referenced this issue Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants