Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Changed to use watch for wait for #169

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

stevehipwell
Copy link
Contributor

This PR switches the logic for wait_for to use a watch.

It depends on #166.

@alekc
Copy link
Owner

alekc commented Sep 2, 2024

@stevehipwell #166 has been merged

@stevehipwell stevehipwell changed the title feat: Changed to use watch for wait rollout feat: Changed to use watch for wait for Sep 2, 2024
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@stevehipwell stevehipwell marked this pull request as ready for review September 2, 2024 11:48
@stevehipwell
Copy link
Contributor Author

@alekc this should now be ready for review.

@alekc alekc merged commit b812a0b into alekc:master Sep 5, 2024
37 checks passed
@stevehipwell stevehipwell deleted the wait-for-watch branch September 5, 2024 14:28
@alekc
Copy link
Owner

alekc commented Sep 6, 2024

@stevehipwell released under

terraform {
  required_providers {
    kubectl = {
      source = "alekc/kubectl"
      version = "2.1.0-beta2"
    }
  }
}

I will do another round of testing and once happy will release the 2.1.0

Thanks for contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants