Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Initial pcp docker image #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ieugen
Copy link
Contributor

@ieugen ieugen commented Aug 22, 2021

  • Addresses image building part from Provide and publish docker image #10
  • Provide a docker image for pcp - server and cli
  • TODO: Provide docker-compose example setup
  • TODO: Provide kubernetes chart example

@ieugen
Copy link
Contributor Author

ieugen commented Aug 22, 2021

@alekcz I would like to see Docker support for pcp.
I deploy and work with containers and I'm sure a lot of other people would deploy it like this as well.

This is a work in progress and feedback is welcomed.

@alekcz
Copy link
Owner

alekcz commented Aug 23, 2021

Thanks for this. I'll have a looksee this evening

@ieugen
Copy link
Contributor Author

ieugen commented Aug 23, 2021

Thanks.

I'll have some questions & suggestions once I start using the PCP container.
I did not have time to finish it.

@ieugen
Copy link
Contributor Author

ieugen commented Aug 25, 2021

Can we avoid the utility for docker deployment?
Docker is designed to run a single processes.
It can run multiple processes but I think we can avoid that for this kind of use cases.

WDYT?

* initial artifact build inside docker
* Docs on how to build and run docker image

Signed-off-by: Eugen Stan <eugen.stan@netdava.com>
@ieugen
Copy link
Contributor Author

ieugen commented Aug 25, 2021

I've added instructions on how to build and also work with the image to deploy a website.
Docker container can be used for local development.

@alekcz
Copy link
Owner

alekcz commented Aug 26, 2021

Can we avoid the utility for docker deployment?
Docker is designed to run a single processes.
It can run multiple processes but I think we can avoid that for this kind of use cases.

WDYT?

I think so. In the next release I want to be able to add the passphrase via HTTP request.
That way we end up with 2 docker images. One for the CLI for developers to use. And the second image is for deployment to the server. Does that make sense?

@ieugen
Copy link
Contributor Author

ieugen commented Aug 27, 2021

That way we end up with 2 docker images. One for the CLI for developers to use. And the second image is for deployment to the server. Does that make sense?

Depending on the size it could be the same image - to keep things simple.

In the next release I want to be able to add the passphrase via HTTP request.

This sounds strange - but I'm not familiar with pcp inner working.
Why would I need a passphrase? Is there a publish/upload step involved?
If so, then a token passed via header could be the solution.
I would go with Authorization: Bearer xxxx, where xxx is an opaque string - that could be a token to be decoded in more advanced implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants