Allow the use of snapshot versions in release and hotfix while are opened #105
Conversation
| * @since 1.9.1 | ||
| */ | ||
| @Parameter(property = "useSnapshotInHotfix", defaultValue = "false") | ||
| protected boolean useSnapshotInHotfix; |
There was a problem hiding this comment.
It is better to put parameters in the appropriate goals.
There was a problem hiding this comment.
I put them in the abstract class to avoid duplication.
I have seen that you have the properties in each goal.
I change it.
| @@ -223,9 +223,23 @@ public void execute() throws MojoExecutionException, MojoFailureException { | |||
| // get current project version from pom | |||
| final String currentVersion = getCurrentProjectVersion(); | |||
|
|
|||
| if ((commitDevelopmentVersionAtStart && useSnapshotInRelease) && ArtifactUtils.isSnapshot(currentVersion)) { | |||
There was a problem hiding this comment.
Why commitDevelopmentVersionAtStart should be enabled?
There was a problem hiding this comment.
I remove this check.
| @@ -179,10 +180,14 @@ public void execute() throws MojoExecutionException, MojoFailureException { | |||
| } | |||
|
|
|||
| if (commitDevelopmentVersionAtStart) { | |||
| String projectVersion = releaseVersion; | |||
| if (useSnapshotInRelease && !ArtifactUtils.isSnapshot(projectVersion)) { | |||
| projectVersion = projectVersion + "-SNAPSHOT"; | |||
There was a problem hiding this comment.
There is Artifact.SNAPSHOT_VERSION constant.
| @@ -177,9 +177,23 @@ public void execute() throws MojoExecutionException, MojoFailureException { | |||
| gitMergeNoff(hotfixBranchName); | |||
|
|
|||
| final String currentVersion = getCurrentProjectVersion(); | |||
| if (useSnapshotInHotfix && ArtifactUtils.isSnapshot(currentVersion)) { | |||
There was a problem hiding this comment.
Will it work with support branches and release branch?
There was a problem hiding this comment.
This feature work with hotfix and release branches. This feature is not implemented for support branches. Do you think that this should be implemented?
There was a problem hiding this comment.
hotfix will merge into the release branch if the release branch exists. The hotfix of support branch is also a thing. :)
Will it work with them?
| @@ -223,9 +223,23 @@ public void execute() throws MojoExecutionException, MojoFailureException { | |||
| // get current project version from pom | |||
| final String currentVersion = getCurrentProjectVersion(); | |||
|
|
|||
| if ((commitDevelopmentVersionAtStart && useSnapshotInRelease) && ArtifactUtils.isSnapshot(currentVersion)) { | |||
There was a problem hiding this comment.
This creates additional commit in production branch with snapshot version. Production branch should be clean, meaning each commit is deployable, meaning no snapshot version in production.
There was a problem hiding this comment.
In this block of code I'm removing the snapshot suffix when we are using useSnapshotInRelease and the version of artifact is snapshot.
The commit executed over the production branch is clean.
There was a problem hiding this comment.
But this commit is in the production branch.
|
@alsanrum PR merged. Thanks! |
Issue #81 and issue #98