Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix merge pom's conflict on release finish using the option useSnapshotInRelease #123

Merged
merged 2 commits into from
Nov 13, 2018

Conversation

hfatela
Copy link
Contributor

@hfatela hfatela commented Aug 16, 2018

fixes the issue #122

I hit the same problem. I dig into the code and apply the same solution the old gitflow did. The only way to solve this is to set the version of the release into the develop branch before the merge and later revert this change back.

useSnapshotInRelease

Change-Id: Ifab36933ec97ed83de32b2f99d0f105d57eabf7e
@jjlharrison
Copy link

Hey @aleksandr-m, sorry to nudge, but is there a reason (other than the conflict) that this pull request can't be merged? This is a bit of a blocker for us adopting this plugin. Thanks.

@aleksandr-m
Copy link
Owner

@jjlharrison Have you tested this solution? Does it work for you?

@hfatela Can you fix conflicts.

@hfatela
Copy link
Contributor Author

hfatela commented Nov 13, 2018 via email

@pipwilson
Copy link

@hfatela At my workplace we have been using your change in production for a couple of months with no issue. Getting this merged would allow us to stop using our fork :)

@hfatela
Copy link
Contributor Author

hfatela commented Nov 13, 2018

ok, it was easier than I thought, so I did it now.

@aleksandr-m aleksandr-m merged commit fc1c518 into aleksandr-m:master Nov 13, 2018
@aleksandr-m
Copy link
Owner

@hfatela Thanks.

@aleksandr-m
Copy link
Owner

@pipwilson @hfatela 1.11.0 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants