Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions build #252

Closed
wants to merge 6 commits into from

Conversation

beatngu13
Copy link
Contributor

While getting familiar with the project for #250, I thought I'd start with contributing a CI build (couldn't finde one?) via GitHub Actions.

There are two issues, which I also experience locally:

  • The POM says Java version 6, although a dependency (org.codehaus.plexus.classworlds.launcher.Launcher) requires 7. (See this build.)

  • The integration tests are failing and I couldn't find a contributing guide or similar to see what is necessary to make them pass. (See this build.)

What's your take on these?

@aleksandr-m
Copy link
Owner

The POM says Java version 6, although a dependency (org.codehaus.plexus.classworlds.launcher.Launcher) requires 7.

So it is time to update pom.xml

The integration tests are failing and I couldn't find a contributing guide or similar to see what is necessary to make them pass.

They are failing with fatal: bad revision 'HEAD' error in build.log. Seems like there is no refs folder in .git. Maybe git-dir doesn't work as expected.

See https://github.com/aleksandr-m/gitflow-maven-plugin/actions/runs/221024887.

@beatngu13
Copy link
Contributor Author

OK, gonna bump the Java version to 7 (also in the POM and elsewhere if applicable).

Regarding the integration tests: Will dig a little deeper during the weekend and hopefully come up with a fix.

When using Java 6, build says "Unsupported major.minor version 51.0", which equals 7. This is required by the dependency enclosing `org.codehaus.plexus.classworlds.launcher.Launcher`.
@beatngu13 beatngu13 force-pushed the feature/gha-build branch 2 times, most recently from 869ec9e to c3109ac Compare August 31, 2020 19:52
Not entirely sure about this ITs intent, but when comparing it to support-start-2-it, that test also checks for existence of the older ref/tag.
@beatngu13 beatngu13 force-pushed the feature/gha-build branch 2 times, most recently from e72cb41 to b9e1ccc Compare August 31, 2020 21:21
@beatngu13
Copy link
Contributor Author

Added some improvements and made the integration tests pass, unfortunately only locally. The build still fails with fatal: bad revision 'HEAD'. I have to further investigate this.

aleksandr-m added a commit that referenced this pull request Sep 6, 2020
@aleksandr-m
Copy link
Owner

@beatngu13 I've found out why integrations tests were failing - it was missing git user config.

Thank you very much for initial ci script and discovering that java 7 is required!

@aleksandr-m aleksandr-m closed this Sep 6, 2020
@beatngu13 beatngu13 deleted the feature/gha-build branch September 6, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants