-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Actions build #252
Conversation
So it is time to update pom.xml
They are failing with See https://github.com/aleksandr-m/gitflow-maven-plugin/actions/runs/221024887. |
OK, gonna bump the Java version to 7 (also in the POM and elsewhere if applicable). Regarding the integration tests: Will dig a little deeper during the weekend and hopefully come up with a fix. |
When using Java 6, build says "Unsupported major.minor version 51.0", which equals 7. This is required by the dependency enclosing `org.codehaus.plexus.classworlds.launcher.Launcher`.
869ec9e
to
c3109ac
Compare
Not entirely sure about this ITs intent, but when comparing it to support-start-2-it, that test also checks for existence of the older ref/tag.
e72cb41
to
b9e1ccc
Compare
Added some improvements and made the integration tests pass, unfortunately only locally. The build still fails with |
@beatngu13 I've found out why integrations tests were failing - it was missing git user config. Thank you very much for initial ci script and discovering that java 7 is required! |
While getting familiar with the project for #250, I thought I'd start with contributing a CI build (couldn't finde one?) via GitHub Actions.
There are two issues, which I also experience locally:
The POM says Java version 6, although a dependency (
org.codehaus.plexus.classworlds.launcher.Launcher
) requires 7. (See this build.)The integration tests are failing and I couldn't find a contributing guide or similar to see what is necessary to make them pass. (See this build.)
What's your take on these?