Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use releaseStartMessage in releaseFinish if useSnapshotInRelease is true #295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bl4ckh4t3
Copy link

Change the message used to bump version to releaseVersion in releaseFinish step if useSnapshotInRelease is set to true.
Previously both this message, occurring in release branche before merging, and the message on develop branch after merge were the same "Update for next development version".
Now commit message for setting release version is Update versions for release as it is when release version is set during releaseStart step.

@aleksandr-m
Copy link
Owner

@bl4ckh4t3 It feels odd to use start message in finish goal. You can change commit messages in your pom.

@bl4ckh4t3
Copy link
Author

@aleksandr-m you are right. it feels odd. The problem is that when the useSnapshotInRelease is set to true, the releaseFinishMessage commit message is also used in the release branch to commit the update of version to the release one, removing the snapshot for instance. So if in pom the message is customized with "update to next development message" the same string appears also as the commit in release branch, where the real commit message should be something like "update to release version". I know the goal is release finish, but the line of code I changed is not about the development branch but about the release branch that normally is updated in release start goal unless useSnapshotInRelease is true. Maybe a new commit message for this scenario can be added so that it can be customized the same way it can be done if useSnapshotInRelease is false

@aleksandr-m
Copy link
Owner

You can customize it to be something more neutral. If it is really so important to you and you cannot change it to be more appropriate, then I guess we can add yet another message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants