Makes update of outputTimestamp property optional #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksandr-m
requested changes
Sep 1, 2021
src/main/java/com/amashchenko/maven/plugin/gitflow/AbstractGitFlowMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amashchenko/maven/plugin/gitflow/AbstractGitFlowMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amashchenko/maven/plugin/gitflow/AbstractGitFlowMojo.java
Outdated
Show resolved
Hide resolved
aleksandr-m
approved these changes
Sep 3, 2021
|
@elektro-wolle Thank you for the PR and explanation. |
|
@elektro-wolle 1.17.0 is out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
outputTimestampto be set to a fix value, not the current Date. In my use-case,project.build.outputTimestampis set to${git.commit.time}in the pom and allows a binary reproducible build of any given tag/commit-id. Whether it is a release or not.But using a fixed timestamp during development commits breaks (in my case) things like
last-modifiedheaders in http responses.