Reload Project and recursively all Modules

[dirk-kaspar]

The Changes suggested from @beatngu13 in Issue #130

[dirk-kaspar]

Thats the first time I've used BeanShell. So please tell me if I have done something weird or strange 😃

[aleksandr-m]

The test seems to hold too much, probably some simple goal would be enough, but it is not a big deal.

Can you think of any negative impact of building all the projects can lead to?

Please squash all changes to single commit and force push to this branch.

[dirk-kaspar]

I would love to see a simpler, more elegant solution! But that was the naive solution to demonstrate our Problem.
Building all the projects in this case is reloading all the pom and build the Model; Not an actual build for those modules or am I wrong?

All commits squashed.

[aleksandr-m]

Any reason to use continue instead of positive if and return? Also can you use brackets {} even for one line if.

[dirk-kaspar]

With JDK 8 onward I would write it like

    private MavenProject reloadProject(final MavenProject project) throws MojoFailureException {
        try {
            return projectBuilder
                    .build(
                            Collections.singletonList(project.getFile()),
                            true,
                            mavenSession.getProjectBuildingRequest())
                    .stream()
                    .map(ProjectBuildingResult::getProject)
                    .filter(MavenProject::isExecutionRoot)
                    .findAny().orElseThrow(() -> new NoSuchElementException(
                            "None of the  ProjectBuildingResults is for the executionRoot"));
        } catch (Exception e) {
            throw new MojoFailureException("Error re-loading project info", e);
        }
    }

The notation with continue seems closer to the stream filter notation to me. But I don't mind changing it to a positive if condition.

[aleksandr-m]

Well, let's see how it behaves in real life then :)

[beatngu13]

Nitpick: Some POMs end with a newline (like this), others don't (like src/it/release-start-finish-2-it/expectations/develop/withAgregatorAsParent/expected-pom.xml).

[dirk-kaspar]

also some pom.xml files hat an indentation with of only two spaces. Fixed that too.

[beatngu13]

The test seems to hold too much, probably some simple goal would be enough, but it is not a big deal.

This is my gut feeling, too. @dirk-kaspar let's have a look afterwards, maybe we can open another PR improving (i.e. minimizing) the IT.

Can you think of any negative impact of building all the projects can lead to?

Performance, maybe? We didn't do a proper performance test, but since we do a complete rebuild, this might increase execution time. On the other hand: we didn't observe anything becoming slower, at least in our pipelines.

[aleksandr-m]

Thank you. Good job!