Fixed a problem that always crashes when executing ft_strrchr
test code.
#146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
ft_strrchr
always crushes withtest_ft_strrchr_electric_memory
.Upon investigation, I found that it was due to
mprotect(ptr, 4096, PROT_NONE);
in theelectric_alloc_rev
function.I measured the page size on my Macbook pro m1 with the following code and it was
16384
.So it should be
mprotect(ptr, 16384, PROT_NONE);
.After modifying the code to allocate memory space based on page size, this problem no longer occurs.