Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: confidential keep sessions fix #256

Merged
merged 6 commits into from
Aug 28, 2024

Conversation

olethanh
Copy link
Contributor

  • Keep session prompot was overriding file
  • Initialize should still be called

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 33.60656% with 81 lines in your changes missing coverage. Please review.

Project coverage is 40.46%. Comparing base (740b156) to head (a66388d).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/aleph_client/commands/instance/__init__.py 17.46% 47 Missing and 5 partials ⚠️
src/aleph_client/commands/utils.py 33.33% 16 Missing ⚠️
src/aleph_client/commands/instance/superfluid.py 60.60% 9 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   38.62%   40.46%   +1.84%     
==========================================
  Files          18       19       +1     
  Lines        1820     1920     +100     
  Branches      310      331      +21     
==========================================
+ Hits          703      777      +74     
- Misses       1097     1107      +10     
- Partials       20       36      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Failed to retrieve llama text: POST 504:

504 Gateway Time-out


The server didn't respond in time.

@olethanh olethanh force-pushed the ol-confidential-session-keep branch from f8a0241 to cf19a33 Compare August 26, 2024 10:07
@Psycojoker Psycojoker requested a review from philogicae August 27, 2024 13:24
@philogicae philogicae merged commit 0b3b85d into master Aug 28, 2024
13 of 18 checks passed
@philogicae philogicae deleted the ol-confidential-session-keep branch August 28, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants