Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow PAYG using base #258

Merged
merged 28 commits into from
Aug 26, 2024
Merged

Feature: Allow PAYG using base #258

merged 28 commits into from
Aug 26, 2024

Conversation

1yam
Copy link
Collaborator

@1yam 1yam commented Aug 22, 2024

Explain what problem this PR is resolving

Related ClickUp, GitHub or Jira tickets : ALEPH-XXX

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.

Documentation

The documentation regarding the impacted features is available on:

URL

The changes in the documentation are available here:

URL

Changes

Explain the changes that were made. The idea is not to list exhaustively all the changes made (GitHub already provides a full diff), but to help the reviewers better understand:

  • which specific file changes go together, e.g: when creating a table in the front-end, there usually is a config file that goes with it
  • the reasoning behind some changes, e.g: deleted files because they are now redundant
  • the behaviour to expect, e.g: tooltip has purple background color because the client likes it so, changed a key in the API response to be consistent with other endpoints

How to test

Explain how to test your PR.
If a specific config is required explain it here (account, data entry, ...)

Print screen / video

Upload here screenshots or videos showing the changes if relevant.

Notes

Things that the reviewers should know: known bugs that are out of the scope of the PR, other trade-offs that were made.
If the PR depends on a PR in another repo, or merges into another PR (i.o. main), it should also be mentioned here

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 37.96296% with 67 lines in your changes missing coverage. Please review.

Project coverage is 40.46%. Comparing base (740b156) to head (9270db5).
Report is 1 commits behind head on master.

Files Patch % Lines
src/aleph_client/commands/instance/__init__.py 22.44% 33 Missing and 5 partials ⚠️
src/aleph_client/commands/utils.py 33.33% 16 Missing ⚠️
src/aleph_client/commands/instance/superfluid.py 60.60% 9 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
+ Coverage   38.62%   40.46%   +1.84%     
==========================================
  Files          18       19       +1     
  Lines        1820     1920     +100     
  Branches      310      331      +21     
==========================================
+ Hits          703      777      +74     
- Misses       1097     1107      +10     
- Partials       20       36      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1yam 1yam marked this pull request as ready for review August 26, 2024 17:15
@aleph-im aleph-im deleted a comment from github-actions bot Aug 26, 2024
@nesitor nesitor merged commit 7a806cf into master Aug 26, 2024
17 of 18 checks passed
@nesitor nesitor deleted the 1yam-payg-base branch August 26, 2024 18:06
@philogicae philogicae mentioned this pull request Aug 26, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants