Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce instance PAYG balance to half #310

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented Dec 2, 2024

Related ClickUp, GitHub or Jira tickets : ALEPH-291

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.

Changes

After changing the instance holding price, we need to put the same on the CLI also.
Also, I increased the limit of the disk size and RAM size, accordingly to the new limits.

How to test

Try to create a normal instance, holding and PAYG and check that the balance required is the half of before.

…me on the CLI also.

Also, I increased the limit of the disk size and RAM size, accordingly to the new limits.
@nesitor nesitor requested review from Psycojoker and 1yam December 2, 2024 10:38
@nesitor nesitor self-assigned this Dec 2, 2024
@aleph-im aleph-im deleted a comment from github-actions bot Dec 2, 2024
Copy link
Collaborator

@1yam 1yam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nesitor nesitor merged commit c864bbf into master Dec 2, 2024
16 of 17 checks passed
@nesitor nesitor deleted the andres-fix-reduce_instance_balance_needed branch December 2, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants