Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix program logs command #318

Merged
merged 4 commits into from
Dec 21, 2024
Merged

Fix program logs command #318

merged 4 commits into from
Dec 21, 2024

Conversation

olethanh
Copy link
Contributor

Endpoint name was changed in the aleph-vm PR but this was not reflected here.
Also move the operate method inside the python sdk

Related ClickUp, GitHub or Jira tickets : continuation of ALEPH-275

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.

How to test

Launch a function you control on a CRN.
Then use aleph program logs <item hash> --domain <crn_url>

The endpoint name was changed in the aleph-vm PR and it was not reflected here

also fix typo
@olethanh olethanh requested a review from nesitor December 13, 2024 10:08
Copy link

Failed to retrieve llama text: POST 500: 500: Unhandled error during initialisation

@olethanh olethanh force-pushed the ol-ALEPH-275-program-logs-cont branch from 4c08068 to 2a6935f Compare December 13, 2024 12:36
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.98%. Comparing base (0cbf7a3) to head (d59526d).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/aleph_client/commands/program.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
+ Coverage   39.50%   39.98%   +0.47%     
==========================================
  Files          18       18              
  Lines        2202     2196       -6     
  Branches      271      270       -1     
==========================================
+ Hits          870      878       +8     
+ Misses       1279     1261      -18     
- Partials       53       57       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olethanh olethanh changed the title Fix progralm logs command Fix program logs command Dec 16, 2024
@olethanh olethanh force-pushed the ol-ALEPH-275-program-logs-cont branch from 63989e6 to 44af4e9 Compare December 16, 2024 09:05
Copy link
Member

@philogicae philogicae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philogicae philogicae merged commit e2cc0b4 into master Dec 21, 2024
16 checks passed
@philogicae philogicae deleted the ol-ALEPH-275-program-logs-cont branch December 21, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants