Fix: use arguments instead of get_closest_tier #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #416 +/- ##
=======================================
Coverage 61.07% 61.07%
=======================================
Files 20 20
Lines 3712 3712
Branches 533 533
=======================================
Hits 2267 2267
Misses 1168 1168
Partials 277 277 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nesitor
approved these changes
Nov 13, 2025
nesitor
added a commit
that referenced
this pull request
Nov 27, 2025
* Problem: Ledger wallet users cannot use Aleph to send transactions. Solution: Implement Ledger use on CLI to allow using them. Do it importing a specific branch of the SDK. * Fix: Solve code quality issues. * Fix: Solve issue loading the good configuration. * Fix: Solved definitively the wallet selection issue and also solved another issue fetching instances from scheduler. * Fix: Solved code-quality issue. * Feature: cli load_account to handle account selections * Fix: using load_account instead of _load_account * fix: unit test mock * Feature: aleph account init to create based config for new user using ledger * fix: aleph account list now handle ledger device * fix: aleph account address now handle ledger device * fix: aleph account export-private-key handle ledger case (can't export private key) * Feature: missing unit test for ledger * fix: Update aleph.im & twentysix to aleph.cloud (#414) Update broken doc links and references to old brand names (aleph.im, twentysix.cloud) to aleph.cloud * Fix: handle common error using ledger (OsError / LedgerError) * Fix: handle change from account on sdk side * Fix: remove init commands and ensure that config file/folder and subfolder are created * Fix: AccountLike renamed to AccountTypes * fix: AlephAccount should bez AccountTypes * fix: account init commands unit test should be removed since not usefull anymore * Fix: use arguments instead of get_closest_tier (#416) * Fix: use arguments instead of get_closest_tier * Fix: ensure that hold can't use --vcpus or --memory or --rootfs_size upper than tier limit * fix: wrong display of vcpus on pricing display * Fix: instance create crn is none when when giving --crn-hash or --crn… (#417) * Fix: instance create crn is none when when giving --crn-hash or --crn-url * fix: linting * Feature: utils functions for ledger * Fix: ensure ledger is connected before loading ledger account * Fix: avoid connecting to ledger when not needed * Fix: use BaseEthAccount instead of EthAccount in instance create and prefetch crn list * fix: refactor aleph account configure and list to handle ledger * Fix: call_program_crn_list can now filter node when fetching if they active or not * Fix: unit test * Feature: --no args for aleph account configure * fix: linting issue * Feature: load acount unit test * Feature: ledger can be load from derivation path * Unit: test_aggregate.py for ledger * Unit: new tests for utils func around ledger (wait_for_ledger_connection, ...) * Unit: new tests for non interactive account config * Problem: Ledger wallet users cannot use Aleph to send transactions. Solution: Implement Ledger use on CLI to allow using them. Do it importing a specific branch of the SDK. * Fix: Solve code quality issues. * Fix: Solve issue loading the good configuration. * Fix: Solved definitively the wallet selection issue and also solved another issue fetching instances from scheduler. * Fix: Solved code-quality issue. * Feature: cli load_account to handle account selections * Fix: using load_account instead of _load_account * fix: unit test mock * Feature: aleph account init to create based config for new user using ledger * fix: aleph account list now handle ledger device * fix: aleph account address now handle ledger device * fix: aleph account export-private-key handle ledger case (can't export private key) * Feature: missing unit test for ledger * Fix: handle common error using ledger (OsError / LedgerError) * Fix: handle change from account on sdk side * Fix: remove init commands and ensure that config file/folder and subfolder are created * Fix: AccountLike renamed to AccountTypes * fix: AlephAccount should bez AccountTypes * fix: account init commands unit test should be removed since not usefull anymore * Feature: utils functions for ledger * Fix: ensure ledger is connected before loading ledger account * Fix: avoid connecting to ledger when not needed * Fix: use BaseEthAccount instead of EthAccount in instance create and prefetch crn list * fix: refactor aleph account configure and list to handle ledger * Fix: call_program_crn_list can now filter node when fetching if they active or not * Fix: unit test * Feature: --no args for aleph account configure * fix: linting issue * Feature: load acount unit test * Feature: ledger can be load from derivation path * Unit: test_aggregate.py for ledger * Unit: new tests for utils func around ledger (wait_for_ledger_connection, ...) * Unit: new tests for non interactive account config * fix: allow user to specify how many ledger account they want to load (default: 5) * fix: use the already existing args chain to load_account * fix: lint issue * Refactor: remove code duplication * Fix: aggregate unit test * Fix: non-evm account couldn't be used using --private-key or --private-key-file * fix: rename --no of configure commands to --non-it * fix: non interactive args for aleph account config is --non-it not --no * Fix: allow user to increase number of ledger account fetch using aleph account configure --ledger-count --------- Co-authored-by: Andres D. Molins <nesitor@gmail.com> Co-authored-by: 1yam <lyam.gomes@epitech.eu> Co-authored-by: Reza Rahemtola <49811529+RezaRahemtola@users.noreply.github.com> Co-authored-by: 1yam <40899431+1yam@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can't create big instance because we take priority on the get_closest_tier instead of the arguments.
So if user want 32 vcpu
it's will given the max tier so 12 vcpu
Self proofreading checklist
Documentation
The documentation regarding the impacted features is available on:
The changes in the documentation are available here:
Changes
This pull request updates the logic for setting resource specifications when creating an instance. The main change is that user-provided values for
vcpus,memory, androotfs_sizewill now override the default specification values from the selected pricing tier, if provided.Resource specification assignment:
src/aleph_client/commands/instance/__init__.py, the assignment ofvcpus,memory, anddisk_sizenow prefers user-supplied values (vcpus,memory,rootfs_size) over the default values fromspecs, allowing for more flexible instance creation.How to test
Launch big instance on superfluid
Notes
If someone who have some token could test it would be perfect