Clean up responses in indexer instances #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data Solution: remove responses when all assigned request nonces have been cleared (when the response has been processed, it removes its nonce from the response)
amalcaraz
reviewed
Feb 23, 2023
amalcaraz
reviewed
Feb 23, 2023
packages/framework/src/services/indexer/src/dal/entityRequestResponse.ts
Outdated
Show resolved
Hide resolved
amalcaraz
reviewed
Feb 23, 2023
Member
Author
|
It should be fixed now and hopefully helps with the overfull Ethereum indexer DB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: indexer instances would get too fat with requestResponseDAL data
Solution: remove responses when all assigned request nonces have been cleared (when the response has been processed, it removes its nonce from the response)