Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check whether we access FtM model from entity/schema/property objects #3091

Closed
tillprochaska opened this issue May 24, 2023 · 1 comment
Closed

Check whether we access FtM model from entity/schema/property objects #3091

tillprochaska opened this issue May 24, 2023 · 1 comment
Labels
backend Issues related to Aleph’s backend, API, CLI etc. Major issue that requires attention

Comments

@tillprochaska
Copy link
Contributor

tillprochaska commented May 24, 2023 •
edited
Loading

We need to check whether this change in FtM breaks things in Aleph and potentially update our code to get rid of it?

Once this change is merged, accessing the FtM model loaded won’t be possible from Schema and Property objects anymore.
@tillprochaska tillprochaska added backend Issues related to Aleph’s backend, API, CLI etc. Major issue that requires attention labels May 24, 2023
@tillprochaska
Copy link
Contributor Author

I did a quick search through the Aleph and ingest-file repos and didn’t find any code that accesses the model from a Schema or Property object, so I guess this likely wouldn’t have an impact on Aleph.

cc @Rosencrantz @catileptic @stchris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Issues related to Aleph’s backend, API, CLI etc. Major issue that requires attention
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tillprochaska