Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove model attribute from Schema and Property #1103

Merged
merged 1 commit into from
Jun 25, 2023
Merged

Conversation

pudo
Copy link
Contributor

@pudo pudo commented May 21, 2023

This makes it much harder to serialise entities using pickle, so it's nice to get rid of it.

@tillprochaska
Copy link
Contributor

tillprochaska commented Jun 20, 2023

@pudo I asked you to hold off releasing this change so we have a chance to see whether it could cause issues in Aleph. Thanks for being patient, we double-checked and as far as we can see it shouldn’t be a problem :)

@pudo
Copy link
Contributor Author

pudo commented Jun 25, 2023

thanks for checking!

@pudo pudo merged commit 5b1c284 into main Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants