Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add make format-check as pull request "check" #3282

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Add make format-check as pull request "check" #3282

merged 1 commit into from
Sep 5, 2023

Conversation

monneyboi
Copy link
Contributor

This adds a pull-request "check" that will run make format-check to check if code from the PR is formatted correctly.

See #3281

@monneyboi monneyboi changed the title Monneyboi/format pull requests Add make format-check as pull request "check" Aug 31, 2023
@monneyboi
Copy link
Contributor Author

monneyboi commented Aug 31, 2023 •
edited
Loading

I've not removed the make format-check from the build workflow. Though it could be argued that is has no place there.

@monneyboi monneyboi requested a review from stchris August 31, 2023 13:48
@monneyboi monneyboi force-pushed the monneyboi/format-pull-requests branch from fcadc5b to 1dbe6f0 Compare August 31, 2023 13:49
@stchris
Copy link
Contributor

stchris commented Sep 1, 2023 •
edited
Loading

Though it could be argued that is has no place there.

I'm not sure I follow, why is the new check better? In my mind checking the formatting should be part of every commit and it should stop building if it encounters errors. Would you agree?

Sorry you explained it in #3281 (comment), just saw that.

@monneyboi monneyboi merged commit 99b93da into alephdata:develop Sep 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stchris stchris stchris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@monneyboi @stchris