Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dashboard icons #1046

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Fix dashboard icons #1046

merged 3 commits into from
Dec 13, 2024

Conversation

mvaivre
Copy link
Member

@mvaivre mvaivre commented Dec 12, 2024

No description provided.

@mvaivre mvaivre requested a review from nop33 December 12, 2024 18:31
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b49eec9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mvaivre mvaivre force-pushed the fix-dashboard-icons branch 2 times, most recently from b5c8f35 to 17aabaf Compare December 12, 2024 18:39
nop33
nop33 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@nop33 nop33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bugs I found don't seem related to this PR, so I'll approve. They can be address in a separate PR.

apps/mobile-wallet/src/components/BalanceSummary.tsx
@@ -67,7 +67,7 @@ export default BalanceSummary
const BalanceSummaryContainer = styled.View`
justify-content: center;
align-items: center;
margin: 10px 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to be able to test the wallet connect modal on ios...

Kapture.2024-12-12.at.22.03.10.mp4

apps/mobile-wallet/src/components/NFTsGrid.tsx
@@ -91,7 +90,6 @@ const NFTsGrid = forwardRef(
export default NFTsGrid

const NFTThumbnailContainer = styled.View`
//margin-bottom: ${gap}px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to this PR, but I was gonna test the NFTs and I see that none is loading. This is our testing wallet which has NFTs on mainnet:

image image

@mvaivre mvaivre force-pushed the fix-dashboard-icons branch from 17aabaf to b49eec9 Compare December 13, 2024 08:41
@mvaivre mvaivre merged commit 3225c0b into fix-ios-font Dec 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nop33 nop33 nop33 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaivre @nop33