MW redesign fixes #1054
MW redesign fixes #1054
Conversation
nop33
commented
Dec 16, 2024
•
nop33
commented
- Fix padding in public keys screen
- Fix back button in public keys screen
- Fix save buttons in contact screen and custom network screen
- Fix top padding of custom network screen
- Fix NFT display
- Fix bg color of info toast
- Fix text color of selected word in mnemonic import
- Fix bottom padding of buttons
- Move submit buttons to bottom of screens
|
nop33
force-pushed
the
mw-redesign-ilias
branch
from
7a91200 to
e93f792
Compare
| @@ -181,7 +182,7 @@ const ScrollViewContainer = styled.View` | |||
| ` | |||
|
|
|||
| const BottomButtonsContainer = styled.View` | |||
| margin: 0 ${DEFAULT_MARGIN}px; | |||
| margin: ${Platform.OS === 'ios' ? 0 : undefined} ${DEFAULT_MARGIN}px; | |||
There was a problem hiding this comment.
On Android this is gonna be margin: undefined XXpx. This doesn't cause any issue?
| headerRight: () => ( | ||
| <ContinueButton title={buttonText || t('Save')} onPress={handleSubmit(onSubmit)} iconProps={undefined} /> | ||
| ), | ||
| headerRight: () => <ContinueButton title={buttonText || t('Save')} onPress={handleSubmit(onSubmit)} />, |
There was a problem hiding this comment.
So as I've done it in other screens, the paradigm changed: main actions should be at the bottom of the screen, wrapped in a BottomButtons container.
There was a problem hiding this comment.
ok, then there are many screens that it this needs to be applied to.
There was a problem hiding this comment.
Applied to following screens:
- AddressFormBaseScreen
- ContactFormBaseScreen
- CustomNetworkScreen
- DecryptScannedMnemonicScreen
Clean up fund password code
