Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

Proxy socks5 support #496

Closed
sven-hash opened this issue Jan 31, 2023 · 14 comments
Closed

Proxy socks5 support #496

sven-hash opened this issue Jan 31, 2023 · 14 comments
Assignees
Labels
feature New feature
Milestone

Comments

@sven-hash
Copy link

Is your feature request related to a problem? Please describe.
It could be nice to support proxy socks5 to add a privacy layer at network level by using Tor (i2p or Nym) for example, and it could enable user without connections restriction to Internet to use the wallet

Describe the solution you'd like
Add the possibility to set a menu where the user could set a proxy socks5 address and port. A connectivity test might be nice but not necessary

Describe alternatives you've considered
The user could set a proxy for the whole system but it's not really a solution since it will forces all the connections to go trough

Additional context
Add any other context or screenshots about the feature request here.

@sven-hash
Copy link
Author

Please correct me if I'm wrong but it seems that you're using electron and it could support proxy by starting the app from CLI with --proxy-server

https://www.electronjs.org/docs/latest/api/command-line-switches#--proxy-serveraddressport

@sven-hash
Copy link
Author

It's seems that the application accept --proxy-server but I cannot get any connections, might try from home

Just found this https://www.npmjs.com/package/electron-proxy-agent

@sven-hash
Copy link
Author

So yes, using C:\Users\<User>\AppData\Local\Programs\alephium-wallet\Alephium.exe --proxy-server=socks5://proxy.notrustverify.ch:443 is working and connect trough Nym mixnet for example

@sven-hash
Copy link
Author

For appimage it works well too alephium-wallet-linux-1.4.0.AppImage --proxy-server=socks5://127.0.0.1:1080

@Sakrecoer Sakrecoer added the feature New feature label Feb 8, 2023
@mvaivre mvaivre added this to the v2.x.x - NEXT milestone May 11, 2023
@mvaivre mvaivre modified the milestones: v2.x.x - NEXT, v2.1.0 Jun 5, 2023
@mvaivre
Copy link
Member

mvaivre commented Jun 13, 2023

@sven-hash @polto We would greatly appreciate if you could test the latest RC with SOCKS5 proxy support: https://github.com/alephium/desktop-wallet/releases/tag/untagged-53d71f8e51fb98c48e49

Go to settings > network to set your proxy URL.

Please share here any issue that you may encounter. Thanks 🙏

@nop33
Copy link
Member

nop33 commented Jun 13, 2023

FYI, this is a draft release and only those with access to the repo can access it I think.

@VDAODAO
Copy link
Member

VDAODAO commented Jun 22, 2023

My feedback @mvaivre

1 - I couldn't get it to work.

As soon as I activate the Nym Connect, I then go in the network settings, activate custom URLs and then input the values (127.0.0.1 - 1080) then press "save", the wallet reloads, and stays stuck like this:

Capture d’écran 2023-06-22 à 16 01 08

At some point the "couldn't connect" error message appears, and the barred wifi symbol is shown up there.

2 - When switching networks (testnet/mainnet) it disconnects from the proxy (and you'd have to manually enter it again)

3 - Option to save proxy config

Everytime I have to input the values again - maybe it'd be cool to have a way to save proxies (for future use).

4 - It keeps the proxy settings when i shut down and open the app again, that's cool.

@polto
Copy link

polto commented Jun 22, 2023

@VDAODAO your NYM connect is running on the phone and the desktop wallet ... well on the desktop. The 127.0.0.1 is an address only available locally, not across devices.

@VDAODAO
Copy link
Member

VDAODAO commented Jun 22, 2023 via email

@sven-hash
Copy link
Author

If you want to test the wallet trough you will need to use a specific service provider for Nym connect. You can use ours, it already whitelist alephium domain (AQRRAs9oc8QWXAFBs44YhCKUny7AyLsfLy91pwmGgxuf.CWUKoKA1afSKyw5BnFJJg19UDgnaVATupsFhQpyTEBHJ@EBT8jTD8o4tKng2NXrrcrzVhJiBnKpT1bJy5CMeArt2w)

Check the screen capture on how to set it. Just type aqr and select it


image
image
image

And then connect, normally it should work

If anybody want to drop me the alephium wallet I can test it (I've got a 404 when trying to access the release)

@polto
Copy link

polto commented Jun 22, 2023

@VDAODAO sorry, because of the look, I thought it was a mobile app. :)

@sven-hash
Copy link
Author

I've to say it's pretty slick to use it and easy to setup. Congrats !

Proof of Working
image

@VDAODAO
Copy link
Member

VDAODAO commented Jun 22, 2023

It works when I do as @sven-hash says.

Rest of my points stand:

2 - When switching networks (testnet/mainnet) it disconnects from the proxy (without you knowing) and you'd have to manually enter it again. (maybe we need a small icon on top that tells you when you are (or not) protected, as Little snitch does for example.

3 - Option to save proxy config, that'd be nice to have.

4 - It keeps the proxy settings when i shut down and open the app again, that's cool.

Thanks @mvaivre @nop33 for the cool feature. Thanks @polto @sven-hash for your help, pardon the beotian!

Sadly testing beyond that (if and how the packets are effectively anon), I can't help :)

@nop33
Copy link
Member

nop33 commented Jul 11, 2023

Merged in master. Closing.

@nop33 nop33 closed this as completed Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature
Projects
None yet
Development

No branches or pull requests

6 participants