-
Notifications
You must be signed in to change notification settings - Fork 44
Conversation
I think we should ask our community members who are also NYM community supporters ? |
I'll have a look into this tmr |
@mvaivre any instructions on how to perform the functional tests? |
You can either use NYM or connect to any other socks5 proxy. On the wallet side, new proxy address / port fields are available in the network settings. Personal experience: I've been able to redirect my trafic through NYM (visible in NYM's logs), but I get a "filter" error telling me that the trafic towards our backend isn't allowed. I didn't find how to configure filters yet when using their NymConnect tool. We should probably try again with their CLI. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't get it to work, following the steps I wrote above... I keep getting ERR_TIMED_OUT
for
GET https://wallet-v20.testnet.alephium.org/infos/chain-params
and being stuck in loading state.
However, if I use Sven's custom provider settings, it works fine, the only thing that I get ERR_TIMED_OUT now is the coingecko API and the token logos from GH
I can send txs. ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from that little comment, I don't have any other comments regarding the code or the functionality!
After resolving the conflicts a functional test might be needed again, but I guess nothing will change in the code-wise
I think the npm audit is fixed in a following PR, don't bother in this one. |
Note for myself: one more thing todo is add a little "experimental" badge next to the feature. |
@nop33 asking for a quick re-review 🙏 |
Functional tests are good ✅ Will merge once tests pass. |
No description provided.