Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

Custom proxy support #720

Merged
merged 18 commits into from
Jul 11, 2023
Merged

Custom proxy support #720

merged 18 commits into from
Jul 11, 2023

Conversation

mvaivre
Copy link
Member

@mvaivre mvaivre commented May 23, 2023

No description provided.

@mvaivre mvaivre changed the base branch from master to next May 23, 2023 09:48
@mvaivre mvaivre marked this pull request as ready for review June 5, 2023 10:24
@mvaivre
Copy link
Member Author

mvaivre commented Jun 5, 2023

@nop33 Not yet asking for a review, but some functional testing with a SOCKS5 proxy. @polto Would you like to try this as well? :)

@polto
Copy link

polto commented Jun 5, 2023

I think we should ask our community members who are also NYM community supporters ?
I am happy to test too. Do I have to compile ? (I am traveling without the machine where I can easily do it)

@nop33
Copy link
Member

nop33 commented Jun 5, 2023

I'll have a look into this tmr

@nop33
Copy link
Member

nop33 commented Jun 6, 2023

@mvaivre any instructions on how to perform the functional tests?

@mvaivre
Copy link
Member Author

mvaivre commented Jun 6, 2023

You can either use NYM or connect to any other socks5 proxy. On the wallet side, new proxy address / port fields are available in the network settings.

Personal experience: I've been able to redirect my trafic through NYM (visible in NYM's logs), but I get a "filter" error telling me that the trafic towards our backend isn't allowed. I didn't find how to configure filters yet when using their NymConnect tool. We should probably try again with their CLI.

@nop33
Copy link
Member

nop33 commented Jun 7, 2023

  1. I downloaded NymConnect and launched it, it told me to paste the address 127.0.0.1 and port 1080 to my app settings
  2. I launched the desktop wallet of this branch and added the above settings in the Network settings tab (connected to testnet)
  3. While all requests going to our services were successful, I am getting ERR_TIMED_OUT for the coingecko request (price, historical chart) as well as for the for the GH requests (fetching token icons from token-list repo).
  4. Sending tx was successful.

@mvaivre mvaivre changed the title [WIP] Custom proxy support Custom proxy support Jun 28, 2023
@mvaivre mvaivre requested a review from nop33 June 28, 2023 12:01
Copy link
Member

@nop33 nop33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't get it to work, following the steps I wrote above... I keep getting ERR_TIMED_OUT for

GET https://wallet-v20.testnet.alephium.org/infos/chain-params

and being stuck in loading state.

However, if I use Sven's custom provider settings, it works fine, the only thing that I get ERR_TIMED_OUT now is the coingecko API and the token logos from GH

I can send txs. ✅

src/modals/SettingsModal/NetworkSettingsSection.tsx Outdated Show resolved Hide resolved
src/types/settings.d.ts Outdated Show resolved Hide resolved
public/preload.js Show resolved Hide resolved
Copy link
Member

@nop33 nop33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that little comment, I don't have any other comments regarding the code or the functionality!

After resolving the conflicts a functional test might be needed again, but I guess nothing will change in the code-wise

public/electron.js Outdated Show resolved Hide resolved
@nop33
Copy link
Member

nop33 commented Jun 29, 2023

I think the npm audit is fixed in a following PR, don't bother in this one.

@mvaivre
Copy link
Member Author

mvaivre commented Jul 6, 2023

Note for myself: one more thing todo is add a little "experimental" badge next to the feature.

@mvaivre mvaivre requested a review from nop33 July 11, 2023 06:46
@mvaivre
Copy link
Member Author

mvaivre commented Jul 11, 2023

@nop33 asking for a quick re-review 🙏

@nop33
Copy link
Member

nop33 commented Jul 11, 2023

Functional tests are good ✅ Will merge once tests pass.

@nop33 nop33 merged commit dd40393 into next Jul 11, 2023
@nop33 nop33 deleted the proxy-support branch July 11, 2023 09:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants