This repository has been archived by the owner on Mar 11, 2024. It is now read-only.
[v2.0] Private key export #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The demo looks great to me. I will leave the strict review to Mika :) |
|
Good job 🤙 Let's deactivate the shortcut to copy an address hash to avoid confusion & mistakes, WDYT? :
|
Done! |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mvaivre
suggested changes
Mar 9, 2023
|
@mvaivre I removed the whole DevTools section because it doesn't make sense to have it when the wallet is locked (you clicking the smart contract buttons wouldn't open any send modal). |
nop33
force-pushed
the
private-key-export
branch
from
e4cde36 to
837c4d5
Compare
nop33
force-pushed
the
private-key-export
branch
from
837c4d5 to
ccc3996
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #484
Kapture.2023-03-08.at.16.42.23.mp4