This repository was archived by the owner on Mar 11, 2024. It is now read-only.
Last before v2.0 #691
Merged
Last before v2.0 #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nop33
commented
May 6, 2023
Comment on lines
+61
to
+66
| const minAlphAmountRequirement = DUST_AMOUNT * BigInt(tokens.length) | ||
| const minDiff = minAlphAmountRequirement - alphAmount | ||
| const totalAlphAmount = minDiff > 0 ? alphAmount + minDiff : alphAmount | ||
|
|
||
| return { | ||
| attoAlphAmount, | ||
| attoAlphAmount: totalAlphAmount.toString(), |
There was a problem hiding this comment.
@mvaivre I had to add this last commit. After the discussion here #682 I realized that we unnecessarily were forcing the user to send an additional 0.001 ALPH per token, no matter if they decide to send ALPH or not. I realized that the min requirement should be added only if the ALPH amount is not enough.
Sorry for breaking the code-freeze, but this was important to fix imo.
mvaivre
approved these changes
May 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for GH to fix its stuff so that I can push my last commit. Thus: WIP