Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quifix for null byte char in string #602

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

tdroxler
Copy link
Member

testnet is down due to this issue #590
We retake the same quickfix as last time, but apply it everywhere, as implementing the above issue might take a bit more time

@tdroxler tdroxler requested a review from h0ngcha0 January 20, 2025 08:52
Copy link
Member

@h0ngcha0 h0ngcha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please build an image? I will apply it on testnet and see if it fixes the issue.

Copy link
Member

@h0ngcha0 h0ngcha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Confirmed that this fixed the issue on testnet.

@tdroxler tdroxler merged commit f7c168e into optimize-finalizing Jan 22, 2025
1 check passed
@tdroxler tdroxler deleted the quifix-null-bytes branch January 22, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants