Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata import from desktop wallet #169

Merged
merged 4 commits into from
Aug 14, 2023
Merged

Metadata import from desktop wallet #169

merged 4 commits into from
Aug 14, 2023

Conversation

nop33
Copy link
Member

@nop33 nop33 commented Aug 8, 2023

🎸 🤘

@mvaivre you might need to delete all previous wallets with deleteAllWallets() in the App.tsx because I made changes in the wallets metadata structure.

@nop33 nop33 requested a review from mvaivre August 8, 2023 16:20
@nop33
Copy link
Member Author

nop33 commented Aug 8, 2023

I got a new dev build for Android, I'll upload it tmr: https://expo.dev/accounts/nop33/projects/mobile-wallet/builds/9b11d2b5-6374-42e5-b264-d12e19fee842

EDIT: Done ✅

@nop33 nop33 changed the base branch from tabs to master August 10, 2023 13:16
@nop33
Copy link
Member Author

nop33 commented Aug 10, 2023

Rebased to fix conflicts

@mvaivre
Copy link
Member

mvaivre commented Aug 13, 2023

On iOS the scan screen is overlapped by the status bar, making it impossible to close.

image

Copy link
Member

@mvaivre mvaivre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm yet to try it on my actual device, but the implementation is super clean, congrats! 👏
I'm approving anyway, we'll test a lot in the upcoming weeks.

@nop33
Copy link
Member Author

nop33 commented Aug 14, 2023

I opened an issue for it: #176

@nop33 nop33 merged commit d97dd43 into master Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants