UI Refactor #194
Merged
UI Refactor #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to upgrade expo to build properly
… changes) This caused severe perfs issues. Will find a workaround.
I may modify the Material version at one point.
…-modals Scrollable modals
Use scaled down left and right components in compact header
Convert address lists to FlatList and fix header glitch
Fix jump when expanding/minimizing
Onboarding cleanup
Header tap scroll top
UI refinements - Standalone headers for most of screens (solves nav header glitches)
nop33
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to test on device more and compare implementations.
It would be especially interesting to compare the 2 different way to implement headers & scroll monitoring:
=> c75ed55 vs. fb8cc77 <=
On my device, the first option (which reuses a same header component instead of mounting new ones) seems to allow for faster transition between screens. However, it comes with its own disadvantages (need to reset scroll state smoothly, some glitches etc.)