Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SASS Support for SASS Plugin #41

Merged
merged 6 commits into from
Nov 19, 2020
Merged

SASS Support for SASS Plugin #41

merged 6 commits into from
Nov 19, 2020

Conversation

shadowtime2000
Copy link
Member

Currently the SASS plugin only supports SCSS #40, this adds a solution for that.

@shadowtime2000 shadowtime2000 requested a review from ije as a code owner November 18, 2020 20:03
@shadowtime2000
Copy link
Member Author

To allow further customization we should probably make sass an object with this code and also a function so that you can supply options for stuff like indent width and indent type.

@shadowtime2000
Copy link
Member Author

Never mind I added that too. Now if you want to use SASS using tabs and an indent width of 10 you can do this:

export default {
	...
	plugins: [sass({ indentType: 'tab', indentWidth: '10' }), ...pluginsHere],
	...
}

but if you want to do the default stuff:

export default {
	...
	plugins: [sass, ...pluginsHere]
	...
}

@yiss yiss mentioned this pull request Nov 18, 2020
@ije
Copy link
Member

ije commented Nov 19, 2020

this is awesome, thanks @shadowtime2000

@ije
Copy link
Member

ije commented Nov 19, 2020

@shadowtime2000 i did some simplification, please check it, thanks

@ije ije linked an issue Nov 19, 2020 that may be closed by this pull request
@ije ije merged commit 364bad1 into alephjs:master Nov 19, 2020
@ije ije mentioned this pull request Nov 22, 2020
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The SASS plugin only support the SCSS syntax
2 participants