Make supervisord log level configurable via env #308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The supervisord log level controls the containers log output regardless of the DEBUG=0|1 flag or other nginx log level settings, thus should be configurable. IMO I'd set log level to warn by default to supress access logs which is desired for most production deployments I suppose. That really depends on the main use-case for this image though. If it's for development setups, then of course debug is totally fine. Also debug won't brake existing behavior. DOCS: the docs need an update to indicate that this can be controlled for docker containers. While we are at it I'd also add the other options of hipervisord that can be controlled this way.
w4tsn
force-pushed
the
feature/supervisord-log-level-env
branch
from
568dea3
to
c85a3c2
Compare
|
LGTM. Thanks! 👍 |
satterly
force-pushed
the
master
branch
3 times, most recently
from
eb9c631
to
b4f2f2c
Compare
|
Thanks for the PR but will prefer #349 as the config setup has changed since this PR was submitted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The supervisord log level controls the containers log output regardless
of the DEBUG=0|1 flag or other nginx log level settings, thus should be
configurable.
IMO I'd set log level to warn by default to supress access logs which
is desired for most production deployments I suppose. That really depends
on the main use-case for this image though. If it's for development setups,
then of course debug is totally fine. Also debug won't brake existing
behavior.
DOCS: the docs need an update to indicate that this can be controlled
for docker containers. While we are at it I'd also add the other options
of hipervisord that can be controlled this way.