[UC05#155#156] Added functionality for users to add own physical cards to one of theirs custom decks #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 8, 2023 12:01
…physical cards additions to custom deck
…llow adding physical cards to custom decks and fixed bug where addButton was not enabled when a card was selected before creating a new deck
This was
linked to
issues
Feb 8, 2023
dstops
approved these changes
Feb 8, 2023
added 3 commits
February 8, 2023 19:26
…stom-Deck-RPC # Conflicts: # src/main/java/com/aadm/cardexchange/server/services/DeckServiceImpl.java # src/main/java/com/aadm/cardexchange/shared/DeckService.java # src/main/java/com/aadm/cardexchange/shared/DeckServiceAsync.java
…o s05_UC15#155#156_Add-Physical-Cards-To-Custom-Deck
| @@ -80,6 +82,7 @@ public DeckWidget(ImperativeHandleDeck deckHandler, ImperativeHandleCustomDeck c | |||
| } | |||
|
|
|||
| public void setData(List<PhysicalCardWithName> data, String selectedCardId) { | |||
| Logger.getLogger("adsasd").info(data.toString()); | |||
There was a problem hiding this comment.
There is a logger to remove
| <g:Button styleName="deckButton {style.showButton}" ui:field="showButton">></g:Button> | ||
| </div> | ||
| <g:HTMLPanel styleName="{style.actions}" ui:field="actions"> | ||
| <!-- <g:Button styleName="deckButton {style.showButton}" ui:field="showButton">></g:Button>--> |
There was a problem hiding this comment.
Also here there's a comment to remove
alessiacrimaldi
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #155, #156 and adds a new method called
addPhysicalCardsToCustomDeckin the DecksActivity to add owned physical cards to a custom deck via RPC call. Additionally, the decks collection has been changed from a HashMap to a LinkedHashMap to ensure the ordering of keys (and thus deck names).Tests for the new method were also added.
Oopsie Doopsie, we've reached 300 tests 🚀