[HOTFIX#193] Fixed acceptProposal RPC for not properly cleaning exchanged cards from custom decks #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from custom decks. Also Refactored acceptProposal RPC for code cleanliness and moved decks updating to separate function, updateUserDecks
Matte0Sacc0
reviewed
Feb 13, 2023
| } | ||
| } | ||
| } else if (deckName.equals(WISHED_DECK)) { | ||
| Map<Integer, List<PhysicalCard>> lookUp = deck.getPhysicalCards().stream().collect( |
There was a problem hiding this comment.
Nice to have the lookup table included in this method seeing that is used only here
Matte0Sacc0
reviewed
Feb 13, 2023
| // save | ||
| deckMap.put(proposal.getReceiverUserEmail(), receiverDecks); | ||
| deckMap.put(proposal.getSenderUserEmail(), senderDecks); | ||
| deckMap.put(proposal.getReceiverUserEmail(), DeckServiceImpl.updateUserDecks(deckMap.get(proposal.getReceiverUserEmail()), proposal.getSenderPhysicalCards(), proposal.getReceiverPhysicalCards())); |
dstops
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug explained in issue #193. Also Refactored acceptProposal RPC for code cleanliness and moved decks updating to separate function
updateUserDecks.