Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gaps #4

Closed
philippowitz opened this issue Mar 20, 2024 · 2 comments · Fixed by #8
Closed

Gaps #4

philippowitz opened this issue Mar 20, 2024 · 2 comments · Fixed by #8
Labels
feature New feature or request

Comments

@philippowitz
Copy link

I'd love the option to add gaps between views.
Additionally, smart gaps would be awesome, similar to e.g. rivercarro, where gaps disappear for single views or the monocle layout.

Thanks you @alex-courtis for this amazing wm!
@alex-courtis
Copy link
Owner

Yes, we can definitely do that. It sounds like inner, outer and smart are necessary.

Please draft the necessary commands, as they would appear in wideriver --help or the man page. I'm not a gaps user so will likely miss something.

As usual, Pull Requests are most gratefully appreciated.

@alex-courtis alex-courtis added the feature New feature or request label Mar 20, 2024
@kyechou
Copy link
Collaborator

kyechou commented Apr 19, 2024 •
edited
Loading

Hi @alex-courtis,

I've implemented the gaps in master...kyechou:wideriver:master, which seems to be working fine on my setup, and all local tests are passing. However, I haven't gotten a chance to add new tests or update the documentation yet. I plan to send a PR after the tests and documentation are updated, but any feedback is welcomed in the meantime.

Thank you for creating the wm!

Edit: all tests and related documentation should be updated (#8)

@kyechou kyechou mentioned this issue Apr 19, 2024
Merged
7 tasks
alex-courtis added a commit that referenced this issue Apr 25, 2024
@kyechou @alex-courtis
feat(#4): add inner, outer and smart gaps (#8)
be87ee1 
* gaps: add inner, outer and smart gaps

* gaps: tests inner, outer and smart gaps

* gaps: apply gaps in monocle mode

* gaps: man and readme

* gaps: man and readme

* gaps: --smart-gaps is a boolean

* gaps: vim-style smart-gaps cli options

---------

Co-authored-by: Alexander Courtis <alex@courtis.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#4): add inner, outer and smart gaps
3 participants
@alex-courtis @kyechou @philippowitz