Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some methods and remove some methods #3

Merged
merged 4 commits into from
Apr 20, 2019
Merged

Add some methods and remove some methods #3

merged 4 commits into from
Apr 20, 2019

Conversation

moba1
Copy link
Collaborator

@moba1 moba1 commented Apr 20, 2019

I added following methods:

  • to_s, inspect: for easy-to-read
  • nothing?, just?: instead of failure? and success?

and remove following methods:

  • failure, success?: due to the above reasons.

#== is implemented for each Just and Nothing and remove Maybe's

@moba1 moba1 requested a review from alex-lairan April 20, 2019 17:33
@moba1 moba1 merged commit fa8e8b7 into master Apr 20, 2019
@moba1 moba1 deleted the add/methods branch April 20, 2019 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-lairan alex-lairan alex-lairan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moba1 @alex-lairan