[RFC] Implement task monad #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-lairan
commented
May 13, 2019
| @kind = Message::None | ||
|
|
||
| def initialize(proc) | ||
| @channel_message = channel_message = Channel::Buffered(Message).new |
There was a problem hiding this comment.
This is a workaround to know if a task is finished.
| end | ||
| end | ||
|
|
||
| def bind(lambda : T -> U) : U forall U |
There was a problem hiding this comment.
This don't realy behave like others bind.
Another name could be used.
spec/monads/task_spec.cr
Outdated
| @@ -0,0 +1,43 @@ | |||
| require "../spec_helper" | |||
|
|
|||
| class Exception | |||
There was a problem hiding this comment.
An exception cannot be compared.
But the Either monad will have an Exception.
I think we could create a class who inherit from an Either for this use case.
alex-lairan
force-pushed
the
feature/add_task
branch
2 times, most recently
from
61fe2c3 to
304612f
Compare
jwoertink
reviewed
May 13, 2019
| value = proc.call | ||
| channel_message.send Message::Value | ||
| channel_value.send value | ||
| rescue exception |
|
@moba1 can you look at this code ? |
moba1
reviewed
May 16, 2019
moba1
approved these changes
May 16, 2019
|
LGTM |
alex-lairan
force-pushed
the
feature/add_task
branch
from
304612f to
68bde01
Compare
|
I disagree, there is the Exception problem, I try to fix it now ! :) |
alex-lairan
force-pushed
the
feature/add_task
branch
from
7a38917 to
0c4ea87
Compare
|
I made a solution :) Take a look |
moba1
approved these changes
May 16, 2019
|
🙆♂ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Task monad to the monads shard.
What is
Taskmonad ?The
Taskmonad permit to run asynchronous action and chain it like a monad.Why Task don't inherit from
Monads::Monad(T)?The Task monad doesn't have the
fmapmethod.Also, it doesn't realy behave like a monad, it could be converted to a monad with
to_eitherorto_maybe.