Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a parameter BookFaviconExt to be able to change favicon extention #455

Closed
wants to merge 1 commit into from

Conversation

syguer
Copy link

@syguer syguer commented Jun 28, 2022

Hi 😄
Thank you for great template!

BTW, my website uses webp as favicon file, and I want to use it on other site using hugo-book too.
But hugo-book supports only favicon.png (right?)
I understand I can use webp if changing template directly.
This PR is a little contribution for thanking.
I hope you like.

Thanks.

@alex-shpak
Copy link
Owner

Hi!
Thanks for the PR, I'm still thinking/considering how to solve it in best way, I'm hestant to add more configuration parameters as it sooner or later will grow out of control. So I'm still thinkig on this one.

@alex-shpak
Copy link
Owner

Perhaps it should be a reference/url of favicon file, rather than just file extension 🤔

@milahu
Copy link

milahu commented Sep 26, 2022

I'm hestant to add more configuration parameters as it sooner or later will grow out of control.

better than forking

{{- if default false .Site.Params.BookFaviconPath -}}
  <link rel="icon" href="{{ .Site.Params.BookFaviconPath | relURL }}"
    type="{{ .Site.Params.BookFaviconMimeType }}">
{{- else -}}
  <link rel="icon" href="{{ "favicon.png" | relURL }}" type="image/png">
{{- end -}}

?

milahu added a commit to milahu/hugo-book that referenced this pull request Sep 26, 2022
alex-shpak added a commit that referenced this pull request Aug 8, 2023
@alex-shpak
Copy link
Owner

I have added BookFavicon option

@alex-shpak alex-shpak closed this Aug 8, 2023
sacgov pushed a commit to sacgov/hugo-book that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants