Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Vite 5 #335

Closed
4 tasks done
undergroundwires opened this issue Nov 16, 2023 · 7 comments
Closed
4 tasks done

Support Vite 5 #335

undergroundwires opened this issue Nov 16, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@undergroundwires
Copy link

Clear and concise description of the problem

Vite 5 is released but this package requires maximum of Vite 4.x as peer-dependency, blocking migrations to Vite 5.

Suggested solution

Support usage with Vite 5.

Alternative

No response

Additional context

No response

Validations
@undergroundwires undergroundwires added the enhancement New feature or request label Nov 16, 2023
@alex8088
Copy link
Owner

Thanks for the reminder, it's under testing

@alex8088
Copy link
Owner

electron-vite 2 beta is out, welcome to test and report issues.

@shayded-exe
Copy link

After updating, rollup is no longer bundling dependencies for the main process. They're all being externalized.

I'm using the split vendor chunk plugin.

@alex8088
Copy link
Owner

@shayded-exe You can set ssr.noExternal to true to make externalizeDepsPlugin work

I will fix this issue.

@SvetBorislavov
Copy link

SvetBorislavov commented Jan 8, 2024 •
edited
Loading

Hi, I am using the beta-4 version and the HMR is not working when i have vue router. In the console I receive a message that the component is updated but the browser is not updating
I have to go to another page and return back to the updated one to trigger the update

@SvetBorislavov
Copy link

Fixed with v2.0.0

@alex8088
Copy link
Owner

alex8088 commented Jan 9, 2024

electron-vite 2.0 is out! 🎉,check out Announcement Blog Post for details.

undergroundwires added a commit to undergroundwires/privacy.sexy that referenced this issue Mar 13, 2024
@undergroundwires
Migrate to Vite 5 and adjust configurations
4ac1425 
This commit updates the `vite` dependency to the latest version (5.1.X)
and makes necessary adjustments to accommodate deprecations and new
features introduced in Vite 5.1.X.

Changes include:

- Modify the import statement for SVG files to use `query: '?raw'` syntax
  due to the deprecation of the `as: raw` option.
- Update `moduleResolution` setting to `Bundler` in `tsconfig.json` to
  support the new TypeScript 5 option, aligning with Vite 5's migration
  guide for Rollup 4 compatibility without requiring file extensions on
  relative imports.

Plugin migrations for Vite 5 support:

- Bump `@modyfi/vite-plugin-yaml`, see @modyfi/vite-plugin-yaml#22.
- Bump `electron-vite`, see alex8088/electron-vite#335.
- Bump `vitejs/plugin-legacy`.
- Bump `vitejs/vite-plugin-vue`, see vitejs/vite-plugin-vue#290.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@shayded-exe @undergroundwires @alex8088 @SvetBorislavov