Set user agent on API requests #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to access the current version number in order to set a sensible user agent. Before that's possible we need to move the definition out of the `__init__.py` file so we don't get circular imports.
The API seems to have started rate limiting requests without a user agent - see #22.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GDELT API seems to have started rate limiting requests without a user agent set (see #22). This PR sets the package name and version as the user agent for all requests to the API. Manual testing for rate limiting is an imprecise business, but I was able to reproduce the error before making this change and I've not seen it since.
This PR also restructures the versioning system slightly - this is needed so we can access the version number to set in the user agent.
Closes #22