Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for more node versions for Travis-CI #49

Closed
tejashah88 opened this issue Jan 31, 2017 · 1 comment
Closed

Add support for more node versions for Travis-CI #49

tejashah88 opened this issue Jan 31, 2017 · 1 comment
Assignees
@tejashah88
Labels
bug? chore

Comments

@tejashah88
Copy link
Member

Currently, the only tested node versions are v6 and v7 (according to travis-ci). It's not very easy to add other versions without some errors encountered, mainly with danger-js (see #48 for attempts by me to solve this issue).

If future releases of alexa-app-server are to intentionally drop support for older versions of node, it's best to add a section in the README stating which versions are supported.
@tejashah88 tejashah88 self-assigned this Jan 31, 2017
@dblock
Copy link
Collaborator

dblock commented Jan 31, 2017

+1 on adding a section for which versions of node are supported

dblock added a commit to dblock/alexa-app-server that referenced this issue Feb 5, 2017
@dblock
Fix alexa-js#49: Added other node versions and reduced tests with cov…
06489ef 
…erage to a single run.
dblock added a commit to dblock/alexa-app-server that referenced this issue Feb 5, 2017
@dblock
Fix alexa-js#49: Added other node versions and reduced tests with cov…
0fa0642 
…erage to a single run.
dblock added a commit to dblock/alexa-app-server that referenced this issue Feb 5, 2017
@dblock
Fix alexa-js#49: Added other node versions and reduced tests with cov…
650d0c1 
…erage to a single run.
@dblock dblock closed this as completed in 8255e5e Feb 5, 2017
dblock added a commit that referenced this issue Feb 5, 2017
@dblock
Merge pull request #66 from dblock/travis-ci-node-versions
0e0913a 
Fix #49: Added other node versions and reduced tests with coverage to a single run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tejashah88 tejashah88

Labels
bug? chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dblock @tejashah88