refactored app-server internals #54
Conversation
|
also important to note: this PR depends on this landing first: alexa-js/alexa-app#144 |
|
I merged #144, I'll try to find time for it, including proper CHANGELOG and UPGRADING from alexa-js/alexa-app#144. Anyone please feel free to pick this up and beat me to it. |
|
@mreinstein I'll review by tomorrow. |
Generated by 🚫 dangerJS |
| @@ -19,8 +19,7 @@ | |||
| }, | |||
| "license": "MIT", | |||
| "dependencies": { | |||
| "alexa-app": "^2.4.0", | |||
| "alexa-verifier-middleware": "^0.1.8", | |||
| "alexa-app": "git+https://github.com/mreinstein/alexa-app.git#352f17cf9b8f541d8f32a385bfff61877b60134e", | |||
There was a problem hiding this comment.
I wouldn't do this, at the very least point it to "alexa-js/alexa-app".
There was a problem hiding this comment.
it was a necessary evil while developing/testing. My hosting environment caches deps aggressively. This absolutely should point at canonical npm version as soon as possible. same goes for entries in examples/apps/*package.json
|
Patiently waiting for this to get pulled in. I have a skill under awaiting certification that I know is going to fail because of the verification piece is not properly working. Hoping to swap this out on my backend before they get to that test (a.k.a. before I fail certification) so I don't have to wait another week. So... let me know if you all need help testing this. ;) |
|
I have a merged version in #56, with a bunch of failing tests. If anyone has quick test fixes, add a comment to that - I'll take a look soon. |
|
Closing this PR in favor of #56 |
|
This PR breaks the debugger completely. The test failures are legit, see #56 for some of the fixes. I was able to fix template rendering, but not POST of actual intent data. |
this shouldn't change the public api at all.
fixes #52 & #21, and partially solves #35
I've deployed this to a test amazon skill and verified that at least the hello_world skill works.
this breaks several tests though. unfortunately I don't have time to update the tests and do the administrative work on this right now. sending this PR so others can review, and pick up where I left off.
Besides the tests and administrative duties, this should be good to go.