Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #55, closes #46. Bind to both HTTP and HTTPs. #60

Merged
merged 7 commits into from
Feb 4, 2017

Conversation

dblock
Copy link
Collaborator

@dblock dblock commented Feb 3, 2017

@tejashah88 Please review/merge.

Closes #58.

@dblock
Copy link
Collaborator Author

dblock commented Feb 3, 2017

This fixes several bugs or obvious misses, too.

/cc: @rickwargo, @mreinstein

Copy link
Member

@tejashah88 tejashah88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Merging...

@tejashah88 tejashah88 merged commit 1461df3 into alexa-js:master Feb 4, 2017
@dblock dblock deleted the revert-55 branch February 4, 2017 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants