Making coveralls work again #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great. @kobim feel free to turn it on for PRs. |
daanzu
pushed a commit
to daanzu/alexa-app
that referenced
this pull request
May 19, 2018
…alls work again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repo's coveralls page didn't update for a long time (since 9/7/17) due to istanbul's version not being compatible with covering spawned processes. (more on that at gotwarlost/istanbul#262).
This PR's coveralls: https://coveralls.io/builds/16371809
Istanbul's 1.x.x-alpha versions solved this issue.
(Istanbul has made version 2 already, but that's another integration we should plan for later.)
I think this is important as we are about to enter few new features (e.g. #313) and we should make sure the new code is properly tested and doesn't reduce the coverage of the package.
(We can also grant repo permission to @coveralls and get reports on each PR.)