Intents and slots prompts confirmation #366
Conversation
fabien88
force-pushed
the
intentsAndSlotsPrompts
branch
5 times, most recently
from
5efead2 to
0126697
Compare
|
This is a great improvement. I'm trying to add a Dialog to a skill right now and finding that I need the exact changes in this PR. This should be merged along with some other changes and a release made, otherwise this framework is going to fall behind the quickly-evolving API. @dblock any thoughts? |
|
This is a great feature! Hope it going to be merged soon. |
There was a problem hiding this comment.
LGTM, but maybe @lazerwalker is a better code reviewer for this?
The build has failed for something that looks legit.
CHANGELOG.md
Outdated
| @@ -5,7 +5,8 @@ | |||
| * [#344](https://github.com/alexa-js/alexa-app/pull/344): Add coveralls as a check for pull requests - [@kobim](https://github.com/kobim). | |||
| * [#352](https://github.com/alexa-js/alexa-app/pull/352): Allow utterance expansion in custom slot type synonyms - [@daanzu](https://github.com/daanzu). | |||
| * [#361](https://github.com/alexa-js/alexa-app/pull/361): Fix object reference for dialogState in in doc - [@Sephtenen](https://github.com/Sephtenen). | |||
| * Your contribution here. | |||
fabien88
force-pushed
the
intentsAndSlotsPrompts
branch
from
0126697 to
39abf5e
Compare
| intent, | ||
| key; | ||
|
|
||
| var creatPrompt = function(promptId, variations) { |
There was a problem hiding this comment.
This should be named createPrompt, yeah?
| var creatPrompt = function(promptId, variations) { | ||
| return { | ||
| id: promptId, | ||
| variations: variations.map(prompt => ({ |
There was a problem hiding this comment.
I wonder if this should check if the user's passed in an already-constructed response object, and if so just use that instead of string-concatenating SSML for them?
I'm not sure if I'm being silly, and maybe there's no reason anyone would want to do that in practice, but seeing SSML being manually constructed like this usually gives me pause.
|
FYI, the CI failures (at least the ones on the latest node) are coming in via dtslint, the linter for our TypeScript type definitions. You need to add the new properties you've added to the appropriate places in the type definitions. |
Intent and slots confirmation with samples prompts like seen in #358