This repository has been archived by the owner on Feb 21, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks so much for this project — looking forward to poking at it as an example!
Node v8 introduced some breaking changes that break versions of
require-dir
prior to0.3.2
. On my local dev machine, which runs Node 8, a clean clone andnpm install
of this repo pulled down an older version ofrequest-dir
that crashes on run.This just bumps the package.json to use a version of
require-dir
that has the node 8 fix. The more proper solution would be to introduce a lockfile of some sort (whether ayarnfile.lock
orpackage-lock.json
), but seeing as this isn't my project I don't want to pick a side on yarn vs npm for you :P.