Accept null playback controls when Alexa sings #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MediaSession is not being updated when Alexa sings.
This is because Moshi crashes when trying to parse
the RenderPlayerInfo.
error: com.squareup.moshi.JsonDataException:
Non-null value 'controls' was null at $.payload.control
AACS expects the 'controls' field of the RenderPlayerInfo
object to be non nullable but this is not the case
when Alexa sings.
{
"audioItemId": "",
"content": {
"art": {
"contentDescription": "Take Me Out to the Ball Game",
"sources": [{
"heightPixels": 0,
"size": null,
"url": "https:\/\/d3l071etx9fo2i.cloudfront.net...",
"widthPixels": 0
}]
},
"background": null,
"header": null,
"headerSubtext1": null,
"mediaLengthInMilliseconds": 0,
"provider": {
"logo": {
"contentDescription": null,
"sources": [{
"heightPixels": null,
"size": null,
"url": "https:\/\/s3.amazonaws.com\/CAPS-...",
"widthPixels": null
}]
},
"name": "Greetings"
},
"title": "Take Me Out to the Ball Game",
"titleSubtext1": "Alexa",
"titleSubtext2": "Greetings"
},
"controls": null
}
Signed-off-by: Rafael Chagas <rafael.chagas@volvo.com>
|
Thanks for the feedback, we have fixed this issue and it will be released in Auto SDK 4.0 release, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MediaSession is not being updated when Alexa sings.
This is because Moshi crashes when trying to parse
the RenderPlayerInfo.
error: com.squareup.moshi.JsonDataException:
Non-null value 'controls' was null at $.payload.control
AACS expects the 'controls' field of the RenderPlayerInfo
object to be non nullable but this is not the case
when Alexa sings.
{
"audioItemId": "",
"content": {
"art": {
"contentDescription": "Take Me Out to the Ball Game",
"sources": [{
"heightPixels": 0,
"size": null,
"url": "https://d3l071etx9fo2i.cloudfront.net...",
"widthPixels": 0
}]
},
"background": null,
"header": null,
"headerSubtext1": null,
"mediaLengthInMilliseconds": 0,
"provider": {
"logo": {
"contentDescription": null,
"sources": [{
"heightPixels": null,
"size": null,
"url": "https://s3.amazonaws.com/CAPS-...",
"widthPixels": null
}]
},
"name": "Greetings"
},
"title": "Take Me Out to the Ball Game",
"titleSubtext1": "Alexa",
"titleSubtext2": "Greetings"
},
"controls": null
}
Signed-off-by: Rafael Chagas rafael.chagas@volvo.com
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.