Change code-formatter from ESLint to Prettier #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shreyas-vgr
approved these changes
Aug 27, 2020
| @@ -0,0 +1,3 @@ | |||
| node_modules | |||
| dist | |||
| coverage | |||
There was a problem hiding this comment.
nit: New line required
Should we add this as a style rule ?
| .nycrc | ||
| .nyc_output | ||
| coverage/ | ||
| coverage/ |
There was a problem hiding this comment.
nit: Same as previous new line at EOF
| ]); | ||
| }); | ||
|
|
||
| test('product value set and changing it requires confirmation and value changed act', async () => { | ||
| const requestHandler = new ControlHandler(new ListControlManager()); | ||
| await testE2E(requestHandler, [ | ||
| 'U: iPhone', TestInput.of(SingleValueControlIntent.of('AppleSuite', { AppleSuite: 'iPhone' })), | ||
| 'U: iPhone', | ||
| TestInput.of(SingleValueControlIntent.of('AppleSuite', { AppleSuite: 'iPhone' })), |
There was a problem hiding this comment.
nit: Is this ok? Kinda looks weird where we had individual lines alternative for User and Alexa earlier?
There was a problem hiding this comment.
Yes there are going to be some cases where the preferred format isn't achieved. I see many reports of people eventually saying they don't mind the change and that the opinionated formatter is liberating. I'm a little skeptical, but I'm willing to try. We might find different ways to address it, and worst case we can use
// prettier-ignore
13 tasks
13 tasks
13 tasks
mikelid-zz
pushed a commit
that referenced
this pull request
Feb 4, 2021
- ControlManager.handleInternalError can produce a complete response, including setting the shouldEndSession flag. - ControlHandler has three modes for handling exceptions that occur during initialization and/or canHandle. - Default - ControlManager.handleInternalError produces response - Alternative #1 - silently return canHandle=false - Alternative #2 - rethrow exception to topLevel BREAKING CHANGE: - the default behavior for an exception thrown during canHandle is changed. Revert to the old behavior by setting ControlHandler.canHandleThrowBehavior = 'Rethrow'
13 tasks
mikelid-zz
pushed a commit
that referenced
this pull request
Feb 4, 2021
- ControlManager.handleInternalError can produce a complete response, including setting the shouldEndSession flag. - ControlHandler has three modes for handling exceptions that occur during initialization and/or canHandle. - Default - ControlManager.handleInternalError produces response - Alternative #1 - silently return canHandle=false - Alternative #2 - rethrow exception to topLevel BREAKING CHANGE: - the default behavior for an exception thrown during canHandle is changed. Revert to the old behavior by setting ControlHandler.canHandleThrowBehavior = 'Rethrow'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prettier/@typescript-eslintto ensure not formatting rules are applied.Motivation and Context
We have been using ESLint as the formatter, however it has some limitations:
Testing
Types of changes
Checklist
License